-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fill-color
option
#27
Conversation
@sindresorhus Any thoughts? |
This looks good for setting a fill color with an image, but there needs to be a way to set just a color too as solid background, per the #19. We can use the transparent image trick. For the API, it could just be an overload of try Wallpaper.set(
NSColor.systemRed,
screen: convertStringToScreen(screen.value)
) (Without As for the CLI, I'm not sure how to model this. Suggestions welcome. |
@medusalix Should I close this? |
@sindresorhus I'm still interested in finishing this (as soon as I'm back on my macOS machine). |
Update from upstream
@sindresorhus I've corrected the usage in the README and renamed the flag to |
I added support for the
fillColor
property to the API and made it accessible through the CLI-option--fill
. Setting the background color without an image URL is not possible, though I looked into the way the system prefpane allows you to choose a custom color. Apparently it stores a transparent picture in the bundles' resources:/System/Library/PreferencePanes/DesktopScreenEffectsPref.prefPane/Contents/Resources/DesktopPictures.prefPane/Contents/Resources/Transparent.tiff
. It might be possible to use this image to add the additional functionality of setting a solid color background to the CLI.IssueHunt Summary
IssueHunt has been backed by the following sponsors. Become a sponsor