Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy events #7

Merged
merged 2 commits into from
May 14, 2020
Merged

Proxy events #7

merged 2 commits into from
May 14, 2020

Conversation

szmarczak
Copy link
Contributor

@szmarczak szmarczak commented May 14, 2020

I forgot to remove the aborted event proxy from my previous PR. The docs were a bit misleading. I've fixed it via placing toStream.destroy() before emitting the aborted event. Also fixed the docs.

Also added proxy for the close event.

I think this is a minor change (3.1.0) 😅

@szmarczak
Copy link
Contributor Author

The only limitation after this PR is to implement the destroy() function: #6 (comment)

But people should do it on their own as replacing stream._destroy is ugly, not safe and people need to pass {autoDestroy: false} anyway.

@sindresorhus
Copy link
Owner

This is failing on Node.js 12.

@szmarczak
Copy link
Contributor Author

Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants