-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add separate base style with good defaults #13
base: main
Are you sure you want to change the base?
Conversation
4930a5c
to
406f2dc
Compare
Looks great! I think a browsers job isn't to provide defaults for accessibility (such as underlines for links) since they're removed so frequently out of misunderstanding why they're there in the first place. Providing a base of better looking defaults could allow designers/developers to learn about accessibility without worrying about overwriting browser defaults. Would love for there to be a default for making This should hopefully motivate more people into using Perhaps the base would be a better place to use system fonts too. |
af8df39
to
f9a9045
Compare
While `modern-normalize.css` is great for ensuring consistency, the default browser styles are not that nice. The goal of `modern-base.css` is to be a better base, that you use in addition to `modern-normalize.css`. This base can afford to be opinionated.
f9a9045
to
36e9e45
Compare
I really like this. The one thought I have is that the |
It causes some many weird problems. I tried `break-word` too, but it also causes problems, like `10%` being split up into two lines of `10` and `%` when using Flexbox.
Would be nice to hear how this intends to differ from sanitize.css, which I've been using for a while to good effect. |
I think a few things from modern-normalize.css should probably go in here, namely the tab size decrease, and the box model change. This would reduce the cognitive load a little bit when deciding whether to adopt modern-normalize.css, because then you don't need to think about whether or not to adopt the opinionated parts or not. (I happen to think the opinionated parts are great, and would include modern-base.css as well, it would just be nice if they were separate.) |
While
modern-normalize.css
is great for ensuring consistency, the default browser styles are not that nice. The goal ofmodern-base.css
is to be a better base style that you use in addition tomodern-normalize.css
. This base can afford to be opinionated.Happy to consider suggestions for what to include, but only essential things.