Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of default fonts #16

Merged
merged 1 commit into from
Feb 11, 2018
Merged

Improve consistency of default fonts #16

merged 1 commit into from
Feb 11, 2018

Conversation

sindresorhus
Copy link
Owner

@sindresorhus sindresorhus commented Feb 9, 2018

Fixes #3

Note to self: Open an issue about including system-ui if this PR is merged.

@sindresorhus sindresorhus mentioned this pull request Feb 9, 2018
Copy link

@anselmh anselmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Unless the relatavely new stack by Github should be incorporated here, this is good to go into stable branch.

@sindresorhus
Copy link
Owner Author

sindresorhus commented Feb 9, 2018

Unless the relatavely new stack by Github should be incorporated here

@anselmh What do you mean? This is using GitHub's exact stack.

@anselmh
Copy link

anselmh commented Feb 9, 2018

😶 I see it from the source code now. Now the entire blog post ist only confusing to me, it seems I completely misinterpreted it, including my statement about Helvetica (I still don’t get github’s decision on that then). What means the Pull Request changes here are totally fine without any concerns.

@Haroenv
Copy link

Haroenv commented Feb 9, 2018

👍

@mdo
Copy link

mdo commented Feb 9, 2018

Y'all should reach out to our Design Systems team (pinging @broccolini) and the Chrome devs. They reached out to us about moving away from the Blink specific font name there, but we had our own challenges when attempting that several months ago I believe.

@broccolini
Copy link

Here's a pr I started which includes some info on the font stack: primer/css#408 re removing BlinkMacSystemFont. I haven't continued as there hasn't been much follow up from the Chrome folks, and there's not a clear positive solution that works for everyone.

@sindresorhus
Copy link
Owner Author

Seems like the safest bet is to stick with what's here until primer/css#408 is resolved or we hear back from Chrome devs. I'll try to ping some people I know.

@sindresorhus sindresorhus merged commit 4e119e0 into master Feb 11, 2018
@sindresorhus sindresorhus deleted the font-stack branch February 11, 2018 12:00
@sindresorhus
Copy link
Owner Author

Continued in #18.

christiankaindl pushed a commit to Flamous/flamous-music that referenced this pull request Dec 25, 2018
We went from modern normalize to normalize.css, because I feel that the latter is bigger and better maintained.

Maybe we will switch in the future again, or make our own...

See (fonts): sindresorhus/modern-normalize#16

and (tab-size): sindresorhus/modern-normalize#17

Thanks modern-normalize!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants