-
-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of default fonts #16
Conversation
1aa3875
to
3e8f9f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Unless the relatavely new stack by Github should be incorporated here, this is good to go into stable branch.
@anselmh What do you mean? This is using GitHub's exact stack. |
😶 I see it from the source code now. Now the entire blog post ist only confusing to me, it seems I completely misinterpreted it, including my statement about Helvetica (I still don’t get github’s decision on that then). What means the Pull Request changes here are totally fine without any concerns. |
👍 |
Y'all should reach out to our Design Systems team (pinging @broccolini) and the Chrome devs. They reached out to us about moving away from the Blink specific font name there, but we had our own challenges when attempting that several months ago I believe. |
Here's a pr I started which includes some info on the font stack: primer/css#408 re removing |
Seems like the safest bet is to stick with what's here until primer/css#408 is resolved or we hear back from Chrome devs. I'll try to ping some people I know. |
Continued in #18. |
We went from modern normalize to normalize.css, because I feel that the latter is bigger and better maintained. Maybe we will switch in the future again, or make our own... See (fonts): sindresorhus/modern-normalize#16 and (tab-size): sindresorhus/modern-normalize#17 Thanks modern-normalize!
Fixes #3
Note to self: Open an issue about including
system-ui
if this PR is merged.