-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure package exists when checking tags #331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably verify that the error contains is not in the npm registry.
so it doesn't hide all errors
@bfred-it Okay, I'll do that. |
🤦♂️ okay should work now. |
Co-Authored-By: jajaperson <[email protected]>
The output of the command on error is: {
"error": {
"code": "E404",
"summary": "'sdfsdfagsdagag' is not in the npm registry.\nYou should bug the author to publish it\n(or use the name yourself!)\n\nNote that you can also install from a\ntarball, folder, http url, or git url.",
"detail": "\n 'sdfsdfagsdagag@latest' is not in the npm registry.\nYour package name is not valid, because \n 1. name can only contain URL-friendly characters\n\nNote that you can also install from a\ntarball, folder, http url, or git url."
}
} I think it would be better to just check the |
@jajaperson Please write a descriptive PR title. |
*bfred-it |
Fixes #179