-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying release branch #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MunifTanjim
changed the title
Add support for specifying relase branch
Add support for specifying release branch
Jul 20, 2020
MunifTanjim
force-pushed
the
feature/branch
branch
2 times, most recently
from
July 20, 2020 16:02
8ebbe07
to
6320763
Compare
MunifTanjim
force-pushed
the
feature/branch
branch
from
July 21, 2020 04:25
6320763
to
98bd346
Compare
MunifTanjim
force-pushed
the
feature/branch
branch
from
July 21, 2020 04:27
98bd346
to
b4bef72
Compare
If this option is not specified, I think we should allow |
So should we hardcode both Lines 41 to 45 in b4bef72
Like this? exports.verifyCurrentBranchIsReleaseBranch = async (releaseBranch) => {
const allowedBranches = releaseBranch ? [releaseBranch] : ['master', 'main']
const currentBranch = await exports.currentBranch()
if (!allowedBranches.includes(currentBranch)) {
throw new Error(`Not on ${allowedBranches.map(branch=> \`${branch}\`).join('/')} branch. Use --any-branch to publish anyway, or set a different release branch using --branch.`);
}
}; |
5 tasks
MunifTanjim
force-pushed
the
feature/branch
branch
from
July 21, 2020 14:23
81007df
to
52856b0
Compare
Correct |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #466
Based on: #476