Add isSilent option
#155
Merged
Add isSilent option
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon93s
commented
Aug 30, 2020
| get isEnabled() { | ||
| return this._isEnabled && !this.isSilent; | ||
| } | ||
|
|
There was a problem hiding this comment.
Converted isEnabled to a getter and forcing it to false when isSilent is true. This reduced the footprint of the PR and prevented double checks of both flags.
| @@ -294,16 +308,19 @@ test('set the correct interval when changing spinner (string case)', t => { | |||
|
|
|||
| spinner.spinner = 'layer'; | |||
|
|
|||
| t.is(spinner.interval, 150); | |||
| const expectedInterval = process.platform === 'win32' ? 130 : 150; | |||
| t.is(spinner.interval, expectedInterval); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Patching/disabling a few tests to pass on Windows.
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
isSilentas discussed in #147.Fixes #147