Require Node.js 12 and move to ESM #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.js
Outdated
| isSymlinkSync | ||
| }; | ||
|
|
||
| export default pathType; |
There was a problem hiding this comment.
There should be no default export
package.json
Outdated
| "engines": { | ||
| "node": ">=8" | ||
| "node": ">=12" |
test/eacces.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| import fs from 'fs'; | |||
| import test from 'ava'; | |||
| import pathType from '../index.js'; | |||
| import * as pathType from '../index.js'; | |||
There was a problem hiding this comment.
This should import named exports.
|
One thing I missed: You didn't update the readme usage example. |
|
Oh - sorry about that, thanks for taking care of it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.