feat(cli): add --chrome-path option (dequelabs#700)

sinedied · Jul 5, 2023 · 7c8978d · 7c8978d
1 parent ca07660
commit 7c8978d
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 2 deletions.
diff --git a/packages/cli/src/bin/cli.test.ts b/packages/cli/src/bin/cli.test.ts
@@ -404,4 +404,15 @@ describe('cli', () => {
       );
     });
   });
+
+  describe('--chrome-path', () => {
+    it('should throw error if path does not exist', async () => {
+      const result = await runCLI(
+        `file://${SIMPLE_HTML_FILE}`,
+        '--chrome-path="someinvalidpath"',
+        '--show-errors'
+      );
+      assert.include(result.stderr, 'no chrome binary at');
+    });
+  });
 });
diff --git a/packages/cli/src/bin/cli.ts b/packages/cli/src/bin/cli.ts
@@ -77,6 +77,10 @@ program
     '--chromedriver-path <path>',
     'Absolute path to the desired chromedriver executable'
   )
+  .option(
+    '--chrome-path <path>',
+    'Absolute path to the desired chrome executable'
+  )
   .action(cli);
 
 program.parse(process.argv);
diff --git a/packages/cli/src/bin/index.ts b/packages/cli/src/bin/index.ts
@@ -36,7 +36,8 @@ const cli = async (
     rules,
     disable,
     loadDelay,
-    chromedriverPath
+    chromedriverPath,
+    chromePath
   } = args;
 
   const showErrors = args.showErrors === true;
@@ -67,7 +68,8 @@ const cli = async (
     browser: args.browser,
     timeout,
     chromeOptions,
-    chromedriverPath
+    chromedriverPath,
+    chromePath
   };
 
   args.driver = startDriver(driverConfigs);

diff --git a/packages/cli/src/lib/webdriver.ts b/packages/cli/src/lib/webdriver.ts
@@ -1,3 +1,4 @@
+import path from 'path';
 import chromedriver from 'chromedriver';
 import { Builder, Capabilities, WebDriver } from 'selenium-webdriver';
 import chrome from 'selenium-webdriver/chrome';
@@ -21,6 +22,10 @@ const startDriver = async (
       }, options);
     }
 
+    if (config.chromePath) {
+      options.setChromeBinaryPath(path.resolve(config.chromePath));
+    }
+
     builder = new Builder()
       .forBrowser('chrome')
       .setChromeOptions(options)

diff --git a/packages/cli/src/types.ts b/packages/cli/src/types.ts
@@ -23,6 +23,7 @@ export interface WebdriverConfigParams {
   browser: string;
   timeout: number;
   chromedriverPath?: string;
+  chromePath?: string;
   path?: string;
   chromeOptions?: string[];
   builder?: Builder;