Added functions for get_selected_streams #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmosorast
reviewed
Jun 19, 2019
There was a problem hiding this comment.
Looks good. I think if it's using the catalog version of things, it should be on the catalog class. That way you can do something like catalog.get_selected_streams() which seems more OO.
I think a non-class version would be good to have too, not sure where it would go though :/
singer/catalog.py
Outdated
| matching_index = 0 | ||
| for i, catalog_entry in enumerate(catalog.streams): | ||
| if catalog_entry.tap_stream_id == currently_syncing: | ||
| matching_index = i |
There was a problem hiding this comment.
You can put a break here once the index is found. Could be a bit of time, depending on how many streams there are (e.g., big database)
judahrand
pushed a commit
to judahrand/singer-python
that referenced
this pull request
Oct 27, 2020
* Added functions for get_selected_streams * refactor functions onto class; pylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.