Resolve references in anyOf schema keys. #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the
resolve_schema_references
method doesn't expand JSON schema references inanyOf
blocks. I added a newSchemaKey
to make sure we recursively expand those$ref
blocks.Are there other keys we should also think about (e.g.
allOf
,oneOf
)? Is there a more generalized approach used elsewhere in Singer for navigating the tree we should consider?