TDL-14621: Add retry logic to requests and TDL-14622: Retry ConnectionResetErrors #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpatel41
requested review from
dbshah1212,
karanpanchal-crest and
savan-chovatiya
dbshah1212
reviewed
Aug 30, 2021
|
|
||
| @mock.patch("FuelSDK.ET_Email.get") | ||
| @mock.patch("time.sleep") | ||
| class TestConnectionResetError(unittest.TestCase): |
There was a problem hiding this comment.
Add tests for all fields. Better to have more unit tests
There was a problem hiding this comment.
Added test cases for all fields.
karanpanchal-crest
approved these changes
Sep 2, 2021
KrisPersonal
requested changes
Oct 7, 2021
| except ConnectionError: | ||
| pass | ||
| # verify the code backed off and requested for 5 times | ||
| self.assertEquals(mocked_get.call_count, 5) |
There was a problem hiding this comment.
For any error we are backing off for 5 times as mentioned at exacttarget_error_handling in dao.py.
@backoff.on_exception(backoff.expo, (socket.timeout, ConnectionError), max_tries=5, factor=2)
| obj.pull_subscribers_batch(['sub1']) | ||
| # verify if 'singer.write_records' was called | ||
| # once as there is only one record | ||
| self.assertEquals(mocked_write_records.call_count, 1) |
There was a problem hiding this comment.
Please add comments to the code.
KrisPersonal
approved these changes
Oct 12, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-14621: Add retry logic to requests
TDL-14622: Retry ConnectionResetErrors
Manual QA steps
Risks
Rollback steps