Add retry logic #22
Merged
Add retry logic #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luandy64
approved these changes
Mar 1, 2022
dsprayberry
added a commit
that referenced
this pull request
Mar 2, 2022
* Store bookmarks with only a midnight time value * Add Changelog * Cleanup bookmarks test * increase no-output timeout * address feedback in PR * Add retry logic (#22) * Add retry logic to the search queries Reference code https://github.com/googleads/google-ads-python/blob/7ee4523d76a159f072541146339e7cb2721a3054/examples/misc/set_custom_client_timeouts.py#L106-L125 * Add error retry and log failed query on exception * fix bookmarks test * Remove selected fields log lines * Silence google's error logging * Prevent backoff from logging google's verbose errors * Deduplicate log critical lines, remove unnecessary error logging * Whitespace clean up * Make pylint happy * Fix field exclusion Metrics and segments are the only fields that have exclusions, but those exclusions can include attributes. And because we have the logic to prefer using the root resource name when checking for `selectable_with`, we don't need to worry about filtering out resources. * Rename `adgroup` to `ad_group` and `audience_performance_report` to `ad_group_audience_performance_report`. Add `campaign_audience_performance_report` * Remove comments * Bump to v0.1.0, update changelog * Update tests to expect new streams * Remove audience_performance_report, update comments * Exclude `ad_group_audience_performance_report` from tests * Renaming streams in discovery test * Making tests happy w/ new stream names * More test stream renaming. Rename confusing Class name to be accurate. * Attempt to catch another Google Internal Error * Make attribute exclusions mutual b/c bidding_strategy * Link PR in Changelog Co-authored-by: dylan-stitch <[email protected]> Co-authored-by: kspeer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds error retry logic and giveup. Logs failed request on giveup / after retry.
QA steps
Risks
Rollback steps