Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keyword fields to click_performace_report #44

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Add keyword fields to click_performace_report #44

merged 1 commit into from
Apr 4, 2022

Conversation

bryantgray
Copy link
Contributor

Description of change

Add two new fields to click_performance_report: click_view_keyword and click_view_keyword_info which includes the subfields match_type and text.

QA steps

  • automated tests passing
  • manual qa steps passing (See: tap-tester/reference/manual_tests)
  • Validated fields were returned
  • Ensured data accuracy
  • Field exclusions are working (click_performance_report has no field exclusions)

Risks

None. Fields are additive and have no effect on current fields. Click performance report has no field exclusions.

Rollback steps

  • revert this branch

@bryantgray bryantgray merged commit 009bfc4 into main Apr 4, 2022
@bryantgray bryantgray mentioned this pull request Apr 4, 2022
Merged
2 tasks
@bryantgray bryantgray deleted the feature/click-view-keyword-fields branch April 4, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsprayberry dsprayberry dsprayberry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantgray @dsprayberry