Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qa/fix build notification #65

Merged
merged 6 commits into from
Jun 15, 2022
Merged

Qa/fix build notification #65

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b256f78
fix slack notif for build
Jun 15, 2022
030c5af
remove click_performance_report from tests
Jun 15, 2022
bd2000d
remove click_performance_report from sync canary test
Jun 15, 2022
bc447ec
run only streams that are untested in canary sync
Jun 15, 2022
ecb2182
just skip canaray test
Jun 15, 2022
225d1d8
put back the assert in the skipped test
Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
pip install 'setuptools==56.0.0'
pip install .[dev]
- slack/notify-on-failure:
only_for_branches: master
only_for_branches: main
- persist_to_workspace:
root: /usr/local/share/virtualenvs
paths:
Expand All @@ -45,7 +45,7 @@ jobs:
echo "$PYLINT_DISABLE_LIST"
pylint tap_google_ads --disable "$PYLINT_DISABLE_LIST"
- slack/notify-on-failure:
only_for_branches: master
only_for_branches: main

run_unit_tests:
executor: docker-executor
Expand All @@ -65,7 +65,7 @@ jobs:
- store_artifacts:
path: htmlcov
- slack/notify-on-failure:
only_for_branches: master
only_for_branches: main

run_integration_tests:
executor: docker-executor
Expand All @@ -89,7 +89,7 @@ jobs:
done
fi
- slack/notify-on-failure:
only_for_branches: master
only_for_branches: main

workflows:
version: 2
Expand Down
11 changes: 6 additions & 5 deletions tests/test_google_ads_automatic_fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,19 @@ def test_happy_path(self):
streams_to_test = {stream for stream in self.expected_streams()
if stream not in {
# no test data available, but can generate
"keywords_performance_report", # needs a Search Campaign (currently have none)
'click_performance_report', # only last 90 days returned
'display_keyword_performance_report', # Singer Display #2, Ad Group 2
'display_topics_performance_report', # Singer Display #2, Ad Group 2
"keywords_performance_report", # needs a Search Campaign (currently have none)
# audiences are unclear on how metrics fall into segments
'campaign_audience_performance_report', # Singer Display #2/Singer Display, Ad Group 2 (maybe?)
'ad_group_audience_performance_report', # Singer Display #2/Singer Display, Ad Group 2 (maybe?)
'campaign_audience_performance_report', # Singer Display #2/Singer Display, Ad Group 2 (maybe?)
# cannot generate test data
'placement_performance_report', # need an app to run javascript to trace conversions
"video_performance_report", # need a video to show
"shopping_performance_report", # need Shopping campaign type, and link to a store
"call_details", # need test call data before data will be returned
"shopping_performance_report", # need Shopping campaign type, and link to a store
"shopping_performance_report", # No automatic keys for this report
"video_performance_report", # need a video to show
'placement_performance_report', # need an app to run javascript to trace conversions
}}

# Run a discovery job
Expand Down
6 changes: 3 additions & 3 deletions tests/test_google_ads_bookmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,16 @@ def test_run(self):

streams_under_test = self.expected_streams() - {
'ad_group_audience_performance_report',
'call_details', # need test call data before data will be returned
'campaign_audience_performance_report',
'click_performance_report', # only last 90 days returned
'display_keyword_performance_report',
'display_topics_performance_report',
'keywords_performance_report',
'placement_performance_report',
'search_query_performance_report',
'shopping_performance_report',
'video_performance_report',
'campaign_audience_performance_report',
'call_details', # need test call data before data will be returned
}

# Run a discovery job
Expand Down Expand Up @@ -93,7 +94,6 @@ def test_run(self):
'placeholder_feed_item_report': data_set_state_value_2,
'age_range_performance_report': data_set_state_value_1,
'account_performance_report': data_set_state_value_1,
'click_performance_report': data_set_state_value_1,
'campaign_performance_report': data_set_state_value_1,
'placeholder_report': data_set_state_value_2,
'ad_performance_report': data_set_state_value_1,
Expand Down
13 changes: 7 additions & 6 deletions tests/test_google_ads_start_date.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,16 @@ def run_test(self):
class StartDateTest1(StartDateTest):

missing_coverage_streams = { # no test data available
'ad_group_audience_performance_report',
'call_details',
'campaign_audience_performance_report',
'click_performance_report', # only last 90 days returned
'display_keyword_performance_report',
'display_topics_performance_report',
'keywords_performance_report',
'placement_performance_report',
"keywords_performance_report",
"video_performance_report",
'ad_group_audience_performance_report',
"shopping_performance_report",
'campaign_audience_performance_report',
'call_details',
'shopping_performance_report',
'video_performance_report',
}

def setUp(self):
Expand Down
6 changes: 3 additions & 3 deletions tests/test_google_ads_sync_canary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,17 +77,17 @@ def test_run(self):
streams_to_test = self.expected_streams() - {
# no test data available, but can generate
"call_details", # need test call data before data will be returned
"click_performance_report", # only last 90 days returned
"display_keyword_performance_report", # Singer Display #2, Ad Group 2
"display_topics_performance_report", # Singer Display #2, Ad Group 2
"keywords_performance_report", # needs a Search Campaign (currently have none)
# audiences are unclear on how metrics fall into segments
"campaign_audience_performance_report", # Singer Display #2/Singer Display, Ad Group 2 (maybe?)
"ad_group_audience_performance_report", # Singer Display #2/Singer Display, Ad Group 2 (maybe?)
"campaign_audience_performance_report", # Singer Display #2/Singer Display, Ad Group 2 (maybe?)
# cannot generate test data
"placement_performance_report", # need an app to run javascript to trace conversions
"video_performance_report", # need a video to show
"shopping_performance_report", # need Shopping campaign type, and link to a store

"video_performance_report", # need a video to show
}

# Run a discovery job
Expand Down