Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In order to get the extra fields from the V3 Deals API, we make a
POST
with (up to) 100 Dealid
s and thehs_date_entered_*
,hs_date_exited_*
, andhs_time_in_*
fields marked as selected.The shape of this
POST
body is:However, this
properties
list can get too long and Hubspot will return a500
.In testing, I noticed that:
properties
key, then some default set of fields is returned<key> : null
Also in testing, I noticed that asking for more than 1000 properties may or may not return a
500
. But looking at the response (and this is dependent on the Hubspot account) most of the fields are null anyway. So we are asking for too much.This PR reduces the "ask" down to just one field to leverage the second bullet above.
Manual QA steps
500
hs_time_in_*
fields were slightly higher on the second set of records, but that makes sense as time has advancedhs_time_in_*
fields differed in my testingRisks
Rollback steps