TDL 19241 add version timestamp in contacts #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prijendev
changed the title
dbshah1212
reviewed
Jun 1, 2022
tests/test_hubspot_all_fields.py
Outdated
| @@ -19,6 +19,12 @@ def get_matching_actual_record_by_pk(expected_primary_key_dict, actual_records): | |||
| can_save = True | |||
| return ret_records | |||
|
|
|||
| FIELDS_ADDED_BY_TAP = { | |||
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. | |||
There was a problem hiding this comment.
Suggested change
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. | |
| # In 'contacts' streams 'versionTimeStamp' is not available in response of the second call. |
Suggested change
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. | |
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. |
There was a problem hiding this comment.
Explain first call and second call in ()
There was a problem hiding this comment.
Explain first call and second call in ()
There was a problem hiding this comment.
Explained first call and second call.
tests/test_hubspot_all_fields.py
Outdated
| @@ -19,6 +19,12 @@ def get_matching_actual_record_by_pk(expected_primary_key_dict, actual_records): | |||
| can_save = True | |||
| return ret_records | |||
|
|
|||
| FIELDS_ADDED_BY_TAP = { | |||
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. | |||
There was a problem hiding this comment.
Suggested change
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. | |
| # In 'contacts' streams 'versionTimeStamp' is not available in response of the second call. |
Suggested change
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. | |
| # In 'contacts' streams 'versionTimeStamp' was not available in response to the second call. |
dbshah1212
approved these changes
Jun 1, 2022
dbshah1212
approved these changes
Jun 1, 2022
savan-chovatiya
approved these changes
Jun 1, 2022
namrata270998
approved these changes
Jun 1, 2022
kspeer825
approved these changes
Jun 1, 2022
KrisPersonal
approved these changes
Jun 3, 2022
Merged
KrisPersonal
pushed a commit
that referenced
this pull request
Jun 14, 2022
* TDL 19241 add version timestamp in contacts (#191) * Added versionTimestamp in contacts stream. * Updated bookmark test case. * Updated comments. * Updated replication method of contacts stream. * TDL 16686 Implement request timeout (#177) * Initial commit for request_timeout * Updated unit test case error * Removed path of unittest file * Updated config file * Updated readme file
Merged
kethan1122
added a commit
that referenced
this pull request
Sep 13, 2022
* TDL 19241 add version timestamp in contacts (#191) * Added versionTimestamp in contacts stream. * Updated bookmark test case. * Updated comments. * Updated replication method of contacts stream. * TDL 16686 Implement request timeout (#177) * Initial commit for request_timeout * Updated unit test case error * Removed path of unittest file * Updated config file * Updated readme file * Initial commit. * Updated interruptes sync offset test case * Resolved comments. * Replaced replication key of deals stream with property_hs_lastmodifieddate field. * Updated discover test case. * Updated ingterrupted_sync test case. * Utilize bookmark of existing connection (#196) * Clearing bookmark for existing connection. * Updated bookmark logic to utilize older bookmark key. * Updated logic to keep older bookmark key in the state. * Added unittest cases. * Updated unit test cases. * Resolved review comments. * Updated get_start to use old bookmark for companies stream method. * Tdl 15447 fix pylint issues (#204) * fixed pylint issues TDL-15447 * changing methods to functions since there is no-self-use * pylint issues * more pylint issues * added pylint disable comment for some scenarios * remove duplicate-code from config.yaml * pylint comment for test_bookmarks * remove duplicate code * removed wrong-import-order Co-authored-by: kethan1122 <[email protected]>
Marcos314
added a commit
to gupy-io/tap-hubspot
that referenced
this pull request
May 11, 2023
* Qa/save test artifacts (singer-io#201) * add logging and save test logs as artifacts * name should be static method so it plays well with BaseCase Co-authored-by: kspeer <[email protected]> * skip fields missing from schema for contact_lists (singer-io#202) Co-authored-by: kspeer <[email protected]> * add limitExempt to all fields test workaround (singer-io#203) Co-authored-by: kspeer <[email protected]> * TDL-19319 Make replication key as automatic inclusion (singer-io#195) * TDL 19241 add version timestamp in contacts (singer-io#191) * Added versionTimestamp in contacts stream. * Updated bookmark test case. * Updated comments. * Updated replication method of contacts stream. * TDL 16686 Implement request timeout (singer-io#177) * Initial commit for request_timeout * Updated unit test case error * Removed path of unittest file * Updated config file * Updated readme file * Initial commit. * Updated interruptes sync offset test case * Resolved comments. * Replaced replication key of deals stream with property_hs_lastmodifieddate field. * Updated discover test case. * Updated ingterrupted_sync test case. * Utilize bookmark of existing connection (singer-io#196) * Clearing bookmark for existing connection. * Updated bookmark logic to utilize older bookmark key. * Updated logic to keep older bookmark key in the state. * Added unittest cases. * Updated unit test cases. * Resolved review comments. * Updated get_start to use old bookmark for companies stream method. * Tdl 15447 fix pylint issues (singer-io#204) * fixed pylint issues TDL-15447 * changing methods to functions since there is no-self-use * pylint issues * more pylint issues * added pylint disable comment for some scenarios * remove duplicate-code from config.yaml * pylint comment for test_bookmarks * remove duplicate code * removed wrong-import-order Co-authored-by: kethan1122 <[email protected]> --------- Co-authored-by: Kyle Speer <[email protected]> Co-authored-by: kspeer <[email protected]> Co-authored-by: Prijen Khokhani <[email protected]> Co-authored-by: kethan1122 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
versionTimestampin the schema of the contacts stream.versionTimestampin the record of the contacts stream.Manual QA steps
Risks
Rollback steps