Integration tests for newly added tickets stream #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger-io/tap-hubspot into integration-tests-tickets-stream
…ger-io/tap-hubspot into integration-tests-tickets-stream
…ger-io/tap-hubspot into integration-tests-tickets-stream
kethan1122
reviewed
Feb 13, 2023
kethan1122
approved these changes
Feb 13, 2023
rdeshmukh15
approved these changes
Feb 13, 2023
RushiT0122
requested changes
Feb 15, 2023
tests/client.py
Outdated
Comment on lines
683
to
689
| records.extend( | ||
| [ | ||
| record | ||
| for record in response["results"] | ||
| if record[replication_key] >= self.start_date_strf.replace('.Z', '.000Z') | ||
| ] | ||
| ) |
There was a problem hiding this comment.
Suggested change
| records.extend( | |
| [ | |
| record | |
| for record in response["results"] | |
| if record[replication_key] >= self.start_date_strf.replace('.Z', '.000Z') | |
| ] | |
| ) | |
| records.extend([record | |
| for record in response["results"] | |
| if record[replication_key] >= self.start_date_strf.replace('.Z', '.000Z')]) |
There was a problem hiding this comment.
This code has mix coding styles but for list comprehession lets use above style like used elsewhere in the same file.
Comment on lines
41
to
44
| tickets_bookmark = self.timedelta_formatted( | ||
| reference_state['bookmarks']['engagements']['lastUpdated'], | ||
| days=-1, str_format=self.BASIC_DATE_FORMAT | ||
| ) |
There was a problem hiding this comment.
Suggested change
| tickets_bookmark = self.timedelta_formatted( | |
| reference_state['bookmarks']['engagements']['lastUpdated'], | |
| days=-1, str_format=self.BASIC_DATE_FORMAT | |
| ) | |
| tickets_bookmark = self.timedelta_formatted( | |
| reference_state['bookmarks']['engagements']['lastUpdated'], | |
| days=-1, str_format=self.BASIC_DATE_FORMAT) |
There was a problem hiding this comment.
Also why are we handlling tickets stream separately?
There was a problem hiding this comment.
we are setting the bookmark value for tickets stream in this way. Followed the existing pattern.
sgandhi1311
force-pushed
the
integration-tests-tickets-stream
branch
from
8cd3259 to
d7d3f1a
Compare
sgandhi1311
force-pushed
the
integration-tests-tickets-stream
branch
from
d7d3f1a to
072f126
Compare
RushiT0122
approved these changes
Feb 15, 2023
sgandhi1311
added a commit
that referenced
this pull request
Feb 16, 2023
* created the tickets schema file * introduced new stream tickets in the hubspot tap implementation * Changes in tickets stream implementation * pylint issues fixed * pylint issues * added unit test to test sync_tickets * Added unit test cases in test_tickets.py * refactoring * added null as one of the types for the non-primary fields in tickets stream schema * added object type in tickets.json * addressed PR comments * removed spaces in tickets.json * changes in tickets.json file * added new line at the end * changed type from integer to string of some of the fields * add logic to transform the records * Integration tests for newly added tickets stream (#219) * add tickets stream in base.py file * get ticket records * add create ticket function for integration test case * test tickets stream in interrupt sync mode * Changes: - add page limit - add functions to get, create, and update the tickets stream * modify get logic for tickets in client.py and update sync offset test * address review comments and reformat the client.py as per the standards * Formatting changes in client.py and bookmark key change in interrupt sync test * bump related changes --------- Co-authored-by: Sourabh Gandhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Note - Dependent on #https://github.com/stitchdata/environments/pull/764
Manual QA steps
Risks
Rollback steps