Fix bookmarking late record updates during sync #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgandhi1311
reviewed
Apr 25, 2023
tap_hubspot/tests/test_deals.py
Outdated
| @@ -1,14 +1,19 @@ | |||
| from tap_hubspot import sync_deals | |||
| from unittest.mock import patch, ANY | |||
|
|
|||
| # from debugpy import listen, wait_for_client | |||
| # listen(8000) | |||
| # wait_for_client() | |||
There was a problem hiding this comment.
remove these debugger lines
sgandhi1311
approved these changes
Apr 25, 2023
kethan1122
added a commit
that referenced
this pull request
Apr 26, 2023
* use sync start time to bookmark contacts stream * Fix bookmarking late record updates during sync (#227) * update bookmarking for records updated between sync * fix bookmarking and interrupted sync integration tests * update unit test --------- Co-authored-by: RushiT0122 <[email protected]> * Changelog and version bump --------- Co-authored-by: RushiT0122 <[email protected]> Co-authored-by: kethan1122 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
To handle records updated between start of the table sync and the end, store the current sync start in the state and not move the bookmark past this value.
Manual QA steps
Risks
Rollback steps