TDL-17520: Primary Key is not unique for the purchase_log stream #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpatel41
requested review from
savan-chovatiya,
dbshah1212 and
karanpanchal-crest
savan-chovatiya
approved these changes
Feb 22, 2022
dbshah1212
approved these changes
Feb 22, 2022
RushiT0122
reviewed
Feb 23, 2022
RushiT0122
approved these changes
Feb 23, 2022
KrisPersonal
approved these changes
Feb 23, 2022
Merged
KrisPersonal
pushed a commit
that referenced
this pull request
Mar 2, 2022
* TDL-17511-Add missing test case, TDL-17522-Fix typos in the fields (#5) * Added all the integration test cases * Added one assertion in discovery test * used pytest with coverage * removed un-used line from config.yml file * reverted the change * updated config.yml file for unittest coverage * removed user_agent from base test file * skip blast_query from start date and bookmark tests * removed unsed imports and updated state bookmark in bookmark test * removed setuptools * resolved bookmark test failure * resolved bookmark test failure * include blast_query stream in test cases Co-authored-by: harshpatel4_crest <[email protected]> * TDL-17521: Fix date_windowing for the purchase_log stream (#9) * Added all the integration test cases * updated date window for purchase log stream * run purchase log stream in start date test * Added one assertion in discovery test * used pytest with coverage * removed un-used line from config.yml file * reverted the change * updated config.yml file for unittest coverage * removed user_agent from base test file * skip blast_query from start date and bookmark tests Co-authored-by: Umang Agrawal <[email protected]> * TDL-17514: Implement request timeout (#6) * Added request timeout * Resolved review comments * run CCi build * updated config,yml file for unittest reports * removed user_agent and imported tap tester libs in base test file Co-authored-by: harshpatel4_crest <[email protected]> * TDL-17515: Verify credentials in discover mode (#7) * Added credentials check in discover mode * updated unittest and run CCi * removed user_agent from base file test * imported runner in base test file * imported menagerie in base test file Co-authored-by: harshpatel4_crest <[email protected]> * TDL-17516: Add custom exception handling (#8) * added exception handling * updated 404 error message * added 500 error class and comments * run CCi build and updated unittest assertion * updated config.yml file * updated config.yml file * removed user_agent from base test file * imported tap tester libs in base * TDL-17520: Primary Key is not unique for the purchase_log stream (#10) * updated primary key for purchase_log stream * removed user_agent from base test file * imported tap_tester in base test file * added channel in the primary key for purchase log * resolve pylint error * resolve unittest failure * skip 403 and 99 error, updated automatic test case for purchase_log stream Co-authored-by: Umang Agrawal <[email protected]> Co-authored-by: Umang Agrawal <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>
Merged
somethingmorerelevant
deleted the
TDL-17520-purchase-logs-primary-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-17520: Primary Key is not unique for the purchase_log stream
['date', 'email_hash', 'extid', 'message_id', 'price', 'channel']as the Primary KeyNOTE: the build is failing due to integration tests failure but that is fixed and all tests are written as part of #5
Manual QA steps
Risks
Rollback steps