Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-21954 & TDL-21991 Bugfixes #14

Merged
merged 9 commits into from
Mar 2, 2023
Merged

Conversation

somethingmorerelevant
Copy link
Member

@somethingmorerelevant somethingmorerelevant commented Feb 13, 2023

Description of change

  • Addresses Following Tickets TDL-21954 & TDL-21991
  • field datatype change for blast_query stream
    The data received for the key first_ten_clicks_time is in the following format:
    2023-02-14 09:10:13|2023-02-14 09:10:14|2023-02-14 09:10:20|2023-02-14 09:10:26|2023-02-14 09:10:27|2023-02-14 09:10:34|2023-02-14 09:10:35|2023-02-14 09:10:37|2023-02-14 09:10:38
    this does not satisfy the existing schema for this key, thus updating the schema to identify first_ten_clicks_time as an array for date-time string
  • Fixed attributerror bug in transform function while transforming user record TDL-21954
  • Fixed blast_query` APi imit issue for records older than 540 days & Added Unit Test Scenario
  • Fixed issue with tap exiting on no data found in stream
  • Added Support for parallel execution of integration tests #15 Added CircleCi config for parallel exec of tests.
  • Bump Version and remove dependencies  #16 Removed Extra Dependencies

Manual QA steps

  • Cloned Connection and verified fix for TDL-21954

Risks

Rollback steps

  • revert this branch

@somethingmorerelevant somethingmorerelevant marked this pull request as ready for review February 13, 2023 19:11
@somethingmorerelevant somethingmorerelevant changed the title TDL-21954 fix issue with Nonetype object has no attribute 'keys'" TDL-21954 Bugfix Feb 13, 2023
Copy link

@dsprayberry dsprayberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we validated that the fix addresses the customer concern by running a cloned connection on this branch? If so, can we add those manual QA steps to the PR?

@somethingmorerelevant
Copy link
Member Author

Have we validated that the fix addresses the customer concern by running a cloned connection on this branch? If so, can we add those manual QA steps to the PR?

Yes i have cloned the connection and verified this fix.

@somethingmorerelevant somethingmorerelevant changed the title TDL-21954 Bugfix TDL-21954 & TDL-21991 Bugfixes Feb 15, 2023
* removed unwanted dependencies
* Bump Version
for "first_ten_clicks" attribute
@somethingmorerelevant somethingmorerelevant merged commit b17a3ab into main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants