Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: LineHeight button to use MenuAnchor #1986

Merged
merged 9 commits into from
Jul 7, 2024

Conversation

AtlasAutocode
Copy link
Collaborator

Description

Fix: LineHeight button to use MenuAnchor. Modelled changes on that used for header toolbar button.
(There is no rush to merge this fix - whenever it is convenient.)

Related Issues

Additional notes

In my copious free time, I may look to see if font, size, header and lineheight buttons can be consolidated to use a common base class.

Checklist

  • [ X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ X ] I titled the PR using Conventional Commits.
  • [ X ] I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • [ X ] All existing and new tests are passing.
  • [ X ] I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • [ X ] No, this is not a breaking change.

}
},
);
return MenuAnchor(
Copy link
Collaborator

@CatHood0 CatHood0 Jul 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By now MenuAnchor at least with LineHeight does not produce this error where appears below keyboard (at least as far as I tested it), so there should be nothing wrong with this change.

Thank you for taking the time to resolve this issue!.

@singerdmx singerdmx merged commit b61c10a into singerdmx:master Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LineHeight toolbar button popup menu appears disconnected
3 participants