Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Key actions not being handled #2025

Merged
merged 13 commits into from
Jul 16, 2024

Conversation

AtlasAutocode
Copy link
Collaborator

Description

Fix: Page up and page down keys did not work.
Fix: Control + up/down or page-up/down failed to scroll document.
Fix: Up arrow cursor key did not work when font size > 24.
Fix: Outdent after indent text at start of document threw assert failure. Fault was incorrect return from editor RenderEditableContainerBox.childAtPosition when caret positioned at start of document.

Enter any text in empty document. Click the indent toolbar button. Click the outdent toolbar button. Program asserted 'The provided text position is not in the current node' because the container was empty.

Additional notes

Handling of keys on macOS needs review.

Checklist

  • [ X ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ X ] I titled the PR using Conventional Commits.
  • [ X ] I did not modify the CHANGELOG.md nor the package version in pubspec.yaml files.
  • [ X ] All existing and new tests are passing.
  • [ X ] I have run the commands in ./scripts/before_push.sh and it all passed successfully

Breaking Change

Does your PR require developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • [ X ] No, this is not a breaking change.

@singerdmx singerdmx merged commit f3a5e11 into singerdmx:master Jul 16, 2024
2 checks passed
@AtlasAutocode AtlasAutocode deleted the page_up_down branch July 17, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants