Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: manual checking of directionality #2063

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

CatHood0
Copy link
Collaborator

Description

In the last PR that fixed these problems with the RTL languages, a minimal problem was generated, which, although it has no effect on performance or the UI, it is still not efficient because it is better to use the calculation of native Flutter addresses using Directionality.of(context)

  • New feature: Adds new functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Code refactor: Code restructuring that does not affect behavior.
  • Breaking change: Alters existing functionality and requires updates.
  • 🧪 Tests: Adds new tests or modifies existing tests.
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Changes to build or deploy processes.

@singerdmx singerdmx merged commit 493bdbc into singerdmx:master Jul 24, 2024
2 checks passed
@CatHood0 CatHood0 deleted the remove_manual_direction_checking branch November 26, 2024 21:50
@CatHood0 CatHood0 restored the remove_manual_direction_checking branch November 26, 2024 21:50
@CatHood0 CatHood0 deleted the remove_manual_direction_checking branch November 26, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants