Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the automated publishing workflow #2363

Merged
merged 3 commits into from
Nov 9, 2024
Merged

ci: fix the automated publishing workflow #2363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69d56e8
ci: fix incorrect script paths
EchoEllet Nov 9, 2024
16c4e76
chore: fix args order for the publish scripts
EchoEllet Nov 9, 2024
459a95d
ci: add TODO to GitHub release notes issue
EchoEllet Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/gh_release_notes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
id: ${{ github.event.release.id }}
# TODO: Since the version changes in CHANGELOG.md are automated, this won't the expected version, they will be committed on publish
body: ${{ steps.extract-release-notes.outputs.release_notes }}
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
# TODO: Might automate some changes of the CHANGELOG.md (outdated TODO)

- name: 📝 Update package version in pubspec.yaml
run: dart ./update_pubspec_version.dart ./pubspec.yaml ${{ steps.extract_version.outputs.VERSION }}
run: dart ./scripts/update_pubspec_version.dart ${{ steps.extract_version.outputs.VERSION }} ./pubspec.yaml

# - name: 📝 Update CHANGELOG.md to reflect the change
# uses: thomaseizinger/keep-a-changelog-new-release@v2
Expand All @@ -80,7 +80,7 @@ jobs:
# changelogPath: ./CHANGELOG.md

- name: 📝 Update CHANGELOG.md to reflect the change
run: dart ./update_changelog_version.dart ./CHANGELOG.md ${{ steps.extract_version.outputs.VERSION }}
run: dart ./scripts/update_changelog_version.dart ${{ steps.extract_version.outputs.VERSION }} ./CHANGELOG.md

- name: 📄 Print updated pubspec.yaml
run: |
Expand Down
Loading