Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For ios] Saving image that's filename does not end with it's file ex… #651

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Conversation

Develeste
Copy link
Contributor

@Develeste Develeste commented Feb 6, 2022

This is a bug of Gallery Saver Package.
CarnegieTechnologies/gallery_saver#66

It can not save image that's filename does not end with it's file extension like below.
"https://firebasestorage.googleapis.com/v0/b/eventat-4ba96.appspot.com/o/2019-Metrology-Events.jpg?alt=media&token=bfc47032-5173-4b3f-86bb-9659f46b362a"

When I tested for android, It can save image. For ios, It show the success snackbar. but not added to gallery.
So I added some logic.

If imageurl does not end with it's file extension, file extension is added to image url for saving.

…tension

This is a bug of  Gallery Saver Package.
CarnegieTechnologies/gallery_saver#66

It can not save image that's filename does not end with it's file extension like below.
"https://firebasestorage.googleapis.com/v0/b/eventat-4ba96.appspot.com/o/2019-Metrology-Events.jpg?alt=media&token=bfc47032-5173-4b3f-86bb-9659f46b362a"

When I tested for android, It can save image. For ios, It show the success snackbar. but not added to gallery.
So I added some logic.

If imageurl does not end with it's file extension, file extension is added to image url for saving.
@singerdmx singerdmx merged commit 076eaf7 into singerdmx:master Feb 6, 2022
renntbenrennt pushed a commit to renntbenrennt/flutter-quill that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants