-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[c++] Add an abstraction layer between SOMA columns and TileDB dimensions and attributes #3337
Open
Labels
enhancement
New feature or request
Comments
This was
linked to
pull requests
Dec 9, 2024
It was closed automatically. It should be re-opened.
Στις Δευ 6 Ιαν 2025, 16:13 ο χρήστης John Kerl ***@***.***>
έγραψε:
… @jp-dark <https://github.com/jp-dark> jp-dark closed this as completed in
#3424 <#3424> 4 days
ago
@jp-dark <https://github.com/jp-dark> was that intentional? There are
still open PRs on this issue ...
—
Reply to this email directly, view it on GitHub
<#3337 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJCR7ROH7DQSO2HJTCC67BT2JKFQ3AVCNFSM6AAAAABSB5A73KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTGE4TMMJSGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
(That was a GitHub auto-close.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there is a 1-1 mapping between TileDB dimension as index columns in SOMA objects and TileDB attributes and non-index columns. The datatype for index columns should match the supported types for TileDB dimensions and the same holds true for attributes as well.
With the introduction of the
GeometryDataFrame
the two previous condition are not true anymore.soma_geometry
is an index column withbinary
datatype holding WKB encoded geometries. TileDB doesn't support binary blobs as dimensions out of the box and even if it did, spatial indexing would require decoding the underlying WKB blob. To provide spatial indexingGeometryDataFrame
utilizes addition dimensions and makes the actualsoma_geometry
an attribute of typeWKB
.Dimensions and attributes generated internally for indexing should be hidden to the end user and any kind of interaction with that column should be through the original index column name.
This approach requires special handling of that column in multiple places throughout the codebase. Any column in the future that would require special indexing will also face the same issues and would increase the complexity of the codebase.
(UPDATE: SOMA specification removed index columns from
GeometryDataFrame
with the possibility to add it back at a later stage)The text was updated successfully, but these errors were encountered: