-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOMA API v1 experiments [WIP/RFC] #227
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0d61ab
to
2a5c9f7
Compare
83bf2a5
to
1bd3fd1
Compare
21e82a1
to
48fad22
Compare
c6d206f
to
c3511aa
Compare
6c7df06
to
0c92ab1
Compare
Superseded by #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some very, very rough initial work to get a first pass at looking for implementation-level gotchas with the nascent v1 SOMA-API spec.
tests/test_v1_*
at https://github.com/single-cell-data/TileDB-SingleCell/tree/kerl/v1-api-spec/apis/python/testsobs
,var
,X
have ingest-from-arrow workingread
methods exist yet; all ofReadResult
is not implemented yetget_schema
(TileDB schema to Arrow schema) is not implemented yetdelete
is not implemented yetSOMADataFrame
is stored as dense (not the case at the moment, because of these things):exp.obs.read(ids=[0,2,4])
(discontiguous) SEGVs in coredf
accessormulti_index
accessor but we get the runtime errorraise TileDBError("
return_arrow=Truerequires .df indexer
")` (@ihnorton FYI)