[c++/python] Add GeometryDataFrame creation
#3674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x column arrow table
… decouple arrow schema between column schema and column domain
XanthosXanthopoulos
force-pushed
the
xan/sc-59427/geometry-dataframe-python
branch
from
a61a126 to
9080ee3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3674 +/- ##
==========================================
+ Coverage 86.29% 86.35% +0.06%
==========================================
Files 55 55
Lines 6390 6495 +105
==========================================
+ Hits 5514 5609 +95
- Misses 876 886 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
XanthosXanthopoulos
changed the title
GeometryDataFrame creation [WIP]GeometryDataFrame creation
jp-dark
reviewed
Feb 7, 2025
| @@ -65,6 +66,7 @@ void SOMADenseNDArray::create( | |||
| ctx->tiledb_ctx(), | |||
| schema, | |||
| index_columns, | |||
| {}, | |||
There was a problem hiding this comment.
Suggested change
| {}, | |
| std::nullopt, |
jp-dark
reviewed
Feb 7, 2025
Comment on lines
+235
to
+246
| // CHECK( | ||
| // std::vector<double_t>({0}) == | ||
| // std::vector<double_t>(d1span.begin(), d1span.end())); | ||
| // CHECK( | ||
| // std::vector<double_t>({1}) == | ||
| // std::vector<double_t>(d2span.begin(), d2span.end())); | ||
| // CHECK( | ||
| // std::vector<double_t>({0}) == | ||
| // std::vector<double_t>(d3span.begin(), d3span.end())); | ||
| // CHECK( | ||
| // std::vector<double_t>({1}) == | ||
| // std::vector<double_t>(d4span.begin(), d4span.end())); |
There was a problem hiding this comment.
Did you mean to delete these?
jp-dark
reviewed
Feb 7, 2025
| @@ -66,6 +67,7 @@ void SOMASparseNDArray::create( | |||
| ctx->tiledb_ctx(), | |||
| schema, | |||
| index_columns, | |||
| {}, | |||
There was a problem hiding this comment.
Suggested change
| {}, | |
| std::nullopt, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: sc-50295
Changes:
Notes for Reviewer:
Adds basic implementation for
GeometryDataFramein the python API, adds static create method and property accessors.Adapt already existing read methods from arrow tables to work with the newly introduced complex domain (a struct on values) used by
soma_geometrycolumn.