Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Correctly create null-filled enum-of-string columns in tiledbsoma.io #3688

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Feb 11, 2025

Issue and/or context: See #3685.

Changes: Jump through the Pandas and Arrow hoops needed to get an entirely null-filled enum-of-strings column.

Notes for Reviewer:

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (552dfc0) to head (53c4831).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3688      +/-   ##
==========================================
+ Coverage   86.31%   86.36%   +0.05%     
==========================================
  Files          55       55              
  Lines        6495     6497       +2     
==========================================
+ Hits         5606     5611       +5     
+ Misses        889      886       -3     
Flag Coverage Δ
python 86.36% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.36% <100.00%> (+0.05%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl force-pushed the kerl/create-null-filled-categorical-of-string branch from 9c07e22 to a25d918 Compare February 11, 2025 19:27
@johnkerl johnkerl marked this pull request as ready for review February 11, 2025 19:31
@johnkerl johnkerl requested a review from nguyenv February 11, 2025 19:31
@johnkerl johnkerl force-pushed the kerl/create-null-filled-categorical-of-string branch from 5dc29e5 to 53c4831 Compare February 11, 2025 19:39
@johnkerl johnkerl requested a review from jp-dark February 11, 2025 21:06
@johnkerl johnkerl merged commit bd6b6cd into main Feb 11, 2025
13 checks passed
@johnkerl johnkerl deleted the kerl/create-null-filled-categorical-of-string branch February 11, 2025 21:50
@johnkerl
Copy link
Member Author

Thanks @nguyenv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants