Remove misleading 'own' from exception message

The property descriptor is recursively retrieved up the prototype chain. It can by thus often _not_ be owned by the object. Therefore the previous error message was wrong. We even have an explicit test for the sandbox.replace* methods that states this: it("should replace an inherited property", ... This is in opposition to stubs and spies which refuse to replace fields that are not owned by the object, which is somewhat strange ...
sinonjs · Jan 4, 2020 · 8979784 · 8979784
1 parent 7cf7dbc
commit 8979784
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lib/sinon/sandbox.js b/lib/sinon/sandbox.js
@@ -210,7 +210,7 @@ function Sandbox() {
         var descriptor = getPropertyDescriptor(object, property);
 
         if (typeof descriptor === "undefined") {
-            throw new TypeError("Cannot replace non-existent own property " + valueToString(property));
+            throw new TypeError("Cannot replace non-existent property " + valueToString(property));
         }
 
         if (typeof replacement === "undefined") {
@@ -243,7 +243,7 @@ function Sandbox() {
         var descriptor = getPropertyDescriptor(object, property);
 
         if (typeof descriptor === "undefined") {
-            throw new TypeError("Cannot replace non-existent own property " + valueToString(property));
+            throw new TypeError("Cannot replace non-existent property " + valueToString(property));
         }
 
         if (typeof replacement !== "function") {
@@ -271,7 +271,7 @@ function Sandbox() {
         var descriptor = getPropertyDescriptor(object, property);
 
         if (typeof descriptor === "undefined") {
-            throw new TypeError("Cannot replace non-existent own property " + valueToString(property));
+            throw new TypeError("Cannot replace non-existent property " + valueToString(property));
         }
 
         if (typeof replacement !== "function") {

diff --git a/test/sandbox-test.js b/test/sandbox-test.js
@@ -814,7 +814,7 @@ describe("Sandbox", function() {
                     sandbox.replace({}, "i-dont-exist");
                 },
                 {
-                    message: "Cannot replace non-existent own property i-dont-exist",
+                    message: "Cannot replace non-existent property i-dont-exist",
                     name: "TypeError"
                 }
             );
@@ -1014,7 +1014,7 @@ describe("Sandbox", function() {
                     sandbox.replaceGetter({}, "i-dont-exist");
                 },
                 {
-                    message: "Cannot replace non-existent own property i-dont-exist",
+                    message: "Cannot replace non-existent property i-dont-exist",
                     name: "TypeError"
                 }
             );
@@ -1161,7 +1161,7 @@ describe("Sandbox", function() {
                     sandbox.replaceSetter({}, "i-dont-exist");
                 },
                 {
-                    message: "Cannot replace non-existent own property i-dont-exist",
+                    message: "Cannot replace non-existent property i-dont-exist",
                     name: "TypeError"
                 }
             );