Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CJSify fake-timer tests #1116

Merged

Conversation

jonnyreeves
Copy link
Contributor

🚀

@mantoni
Copy link
Member

mantoni commented Aug 5, 2016

Wrestling them down, one by one 👊
Very nice!

@jonnyreeves
Copy link
Contributor Author

aye, slow going - but only a handful to do now - 2.0 is almost there (although I'm slightly concerned that we are going to get blocked by the docs website?)

@jonnyreeves jonnyreeves mentioned this pull request Aug 5, 2016
36 tasks
@fatso83
Copy link
Contributor

fatso83 commented Aug 8, 2016

@jonnyreeves : I don't think the website should hold us back. We'll release 2.0 when 2.0 is finished, not when the revamped site is finished. That being said, me and Roderick had a appear.in session talking about this a week ago, and we have gotten the basic site generation up, so things are rolling. I'll be adding some articles as well so we can ship it with some new content too.

@jonnyreeves
Copy link
Contributor Author

@mantoni good to land?

@mantoni mantoni merged commit 6698de5 into sinonjs:master Aug 13, 2016
@mantoni
Copy link
Member

mantoni commented Aug 13, 2016

👍

@jonnyreeves jonnyreeves deleted the feature/cjsify-fake-timers-tests branch January 8, 2017 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants