Feature/cjsify fake server tests #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Straight forward for the most-part, but the module still relies on the `sinon` module as `fakeServer.create()` still relies on the `sinon` object to instantiate the appropriate XHR Transport.
TBH this module can probably be deprecated; it appears to only be required by legacy environments (jQuery 1.3)
|
LGTM. Thanks! |
|
@jonnyreeves, one of the few last bits remaining for Sinon 2.0 is "Migrate fake_server and friends", where you mention "useFakeXMLHttpRequest still referenced"
I am not quite sure which API will change? I would like to give this a go, but unsure what you are referring to here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another straight forward port.
fake-server-test.jsis still pulling in thesinonmodule as it tests that the globaluseFakeXMLHttpRequestmethod is invoked upon construction of the fakeServer instance. I'll add a note in #966 as it will result in an API change.