Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalise typeOf and extends #1235

Merged
merged 3 commits into from
Jan 8, 2017

Conversation

jonnyreeves
Copy link
Contributor

Purpose (TL;DR) - mandatory

Moves typeOf and extends utility functions into the util/core folder so they are no longer a special case and it's more explicit that these are not part of the sinon public API.

Background (Problem in detail) - optional

Part of the sinon 2.0 roadmap, see #966.

How to verify - mandatory

  • npm test
  • confirmed using a built version that sinon.extend and sinon.typeOf still issue a deprecation warning.

@jonnyreeves jonnyreeves added this to the 2.0 milestone Jan 8, 2017
@jonnyreeves jonnyreeves mentioned this pull request Jan 8, 2017
36 tasks
@coveralls
Copy link

coveralls commented Jan 8, 2017

Coverage Status

Coverage remained the same at 94.896% when pulling c8832ac on jonnyreeves:feature/internalize into 11edb2d on sinonjs:master.

Copy link
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to look twice to understand why the deprecation was still printed after removing it, but I saw it in the end :-)

@fatso83 fatso83 merged commit eb15826 into sinonjs:master Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants