Remove the use of sinon.format from the codebase
#967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test-call` suite now check that the `util/core/format` module was invoked by asserting against the returned string value; this allows us to import `util/core/format` inside both `spy.js` and `call.js` instead of using `sinon.format`
fatso83
added a commit
that referenced
this pull request
Jan 18, 2016
Remove the use of `sinon.format` from the codebase
|
Another one bites the dust 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test-callsuite now check that theutil/core/formatmodule was invoked by asserting against the returned string value; this allows us to importutil/core/formatinside bothspy.jsandcall.jsinstead of usingsinon.format