Re-organise Tests (removes sinon-test.js)
#968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls out 3 suites into `test/util/core/wrap-method-test` for better organisation.
Pulls out a suite into `test/util/core/deep-equal-test` for better organisation.
Pulls out a suite into `test/stub-test` to align with the fact `createStubInstance` is defined (and exposed against) the `spy` module.
Pulls out a suite into `test/util/core/restore-test` for better organisation. As a side note, I am not sure that `sinon.restore` is a core util; should it infact be part of the public API and be moved to `lib/`?
Pulls out a suite into `test/util/core/funciton-to-string-test` for better organisation.
Kills off a single test for `sinon.log` - I'm not convinced anything of value was lost :)
|
Thank you! It's a dirty job, so it's great when someone takes on the task :-) |
fatso83
added a commit
that referenced
this pull request
Jan 18, 2016
Re-organise tests (removes `sinon-test.js`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-organise the contents of the
testfolder so each modules tests are better aligned to their subject's location inlib/.Removes a single test-case for
sinon.log; I wasn't convinced it was worth keeping :)