Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sinon.test() and sinon.testCase. #973

Merged
merged 1 commit into from
Feb 9, 2016

Conversation

jonnyreeves
Copy link
Contributor

Functionality has been extracted out into the sinon-test module allowing us to remove these two tightly coupled methods from sinon's public API.

Oh, just noticed, this removes the last use of sinon.config - we're getting there! 👯

Functionality has been extracted out into the `sinon-test` module allowing us to remove these two tightly coupled methods from sinon's public API.
@jonnyreeves jonnyreeves mentioned this pull request Jan 26, 2016
36 tasks
@jonnyreeves
Copy link
Contributor Author

Hmm; the Node 4.2 build failed for a seemingly unrelated test; could a mod please trigger a rebuild? Thanks! :)

@mroderick
Copy link
Member

Sure

@jonnyreeves
Copy link
Contributor Author

✅ Thanks @mroderick

@mroderick
Copy link
Member

It' didn't work for awhile, restarted several times, asked on IRC ... and suddenly, it works!

@mroderick
Copy link
Member

lol, now another build has started ... /me gets popcorn out

@fatso83
Copy link
Contributor

fatso83 commented Jan 31, 2016

AFAIK, this could be merged now, as the new sinon-test package has been created, but there might be something obvious I am missing?

@jonnyreeves
Copy link
Contributor Author

@fatso83, this should be good to go. For those importing sinon from master and relying on sinon.test or sinon.testCase, you will need to start importing the sinon-test npm module and the configure these methods with:

var sinon = require('sinon');
var sinonTest = require('sinon-test');

sinon.test = sinonTest.configureTest(sinon  /*, config */ );
sinon.testCase = sinonTest.configureTestCase(sinon  /*, config */ );

fatso83 added a commit that referenced this pull request Feb 9, 2016
Remove `sinon.test()` and `sinon.testCase`.
@fatso83 fatso83 merged commit a8b6766 into sinonjs:master Feb 9, 2016
@mroderick
Copy link
Member

@jonnyreeves do you think this means that we can also remove the injected config into sandbox.create(), which is currently documented in sandbox.md?

@fatso83
Copy link
Contributor

fatso83 commented Dec 17, 2016

@jonnyreeves: not sure what you mean by removing the injected config? From where; the API? We cannot remove sandbox.create(config), as this is being used by sinon-test for configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants