-
-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sinon.test()
and sinon.testCase
.
#973
Conversation
Functionality has been extracted out into the `sinon-test` module allowing us to remove these two tightly coupled methods from sinon's public API.
Hmm; the Node 4.2 build failed for a seemingly unrelated test; could a mod please trigger a rebuild? Thanks! :) |
Sure |
✅ Thanks @mroderick |
It' didn't work for awhile, restarted several times, asked on IRC ... and suddenly, it works! |
lol, now another build has started ... /me gets popcorn out |
AFAIK, this could be merged now, as the new |
@fatso83, this should be good to go. For those importing sinon from master and relying on var sinon = require('sinon');
var sinonTest = require('sinon-test');
sinon.test = sinonTest.configureTest(sinon /*, config */ );
sinon.testCase = sinonTest.configureTestCase(sinon /*, config */ ); |
Remove `sinon.test()` and `sinon.testCase`.
@jonnyreeves do you think this means that we can also remove the injected config into |
@jonnyreeves: not sure what you mean by removing the injected config? From where; the API? We cannot remove |
Functionality has been extracted out into the
sinon-test
module allowing us to remove these two tightly coupled methods from sinon's public API.Oh, just noticed, this removes the last use of
sinon.config
- we're getting there! 👯