Hjson & CSON files are automatically converted to JSON now #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry, I didn't want the other commits to be part of this PR. I don't know how to get rid of them now, except for a hard reset but that would probably mess things up... |
|
No problem at all, thanks so much for the contributions! We already have that other commit cued up in #98 and our hope is to merge that as part of the next release, so this should merge cleanly afterwards. If not, we’ll just cherry-pick the commits or something. |
🍒
|
I love the Hjson concept, great to see this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #43, I have implemented support for these two formats. For now, only terraform supports them, building that into Harp won't be as easy I think.