Tables support for IndexedVarArray #30
Conversation
|
The latest changes depend on the availability of Tables support in JuMP (see jump-dev/JuMP.jl#3104) and should await merging until the PR is merged. |
| end | ||
| if length(v) > 0 && !has_values(first(v).model) | ||
| error("No solution values available for variable") | ||
| function _rows(x::Union{SparseArray,SparseVarArray,IndexedVarArray}) |
There was a problem hiding this comment.
Could this be AbstractSparseArray? I guess we are about to delete SparseVarArray in another PR soon.
There was a problem hiding this comment.
The implementation of _rows assumes a data property exists which is not available in general for AbstractSparseArray. Agree that SparseVarArray just can be removed here.
How about just adding rowtable without extending JuMP function while we wait to get all the other changes in and merged and have tests in place, and rework to extend JuMP methods after jump-dev/JuMP.jl#3104 is merged, would that work? |
Codecov ReportBase: 84.26% // Head: 83.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 84.26% 83.95% -0.32%
==========================================
Files 8 6 -2
Lines 445 405 -40
==========================================
- Hits 375 340 -35
+ Misses 70 65 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I have moved rowtable out of JuMP.Containers and fixed tests to run with latest JuMP release. Maybe include this as part of 0.7 release and move back and fix tests when new JuMP version is available? |
Thanks! Good idea, I originally planned to wait for the JuMP release, but I think as long as we don't export |
* Removing SparseVarArray * Remove kwargs for inservar! * Delete most commented-out removals * update JuliaFormatter for CI * In progress: updating tests * formatting fixes * x86 fix * Update tests Remove tables awaiting #30 * Test starting from 1.7 for destructuring * Test coverage * formatting fixes * Delete unused for coverage * SparseArray coverage * Formatting fixes * x86 fixes (Int) * Formatting fix * Update readme and prep for v0.7 * Remove README entry on rowtables for now * Prep release Co-authored-by: Lars Hellemo <[email protected]>
There will probably some alignment with JuMP if Tables support is added to JuMP (ref. jump-dev/JuMP.jl#3096)