#125 do not throw 'could not resolve dependency...' exception when fi…

…le for optional dependency could not be resolved
siom79 · Mar 20, 2016 · b27660a · b27660a
1 parent 33f8ad0
commit b27660a
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/japicmp-maven-plugin/src/main/java/japicmp/maven/JApiCmpMojo.java b/japicmp-maven-plugin/src/main/java/japicmp/maven/JApiCmpMojo.java
@@ -612,11 +612,13 @@ private List<File> resolveDependencyToFile(String parameterName, Dependency depe
 			getLog().debug(parameterName + ": " + descriptor);
 			Set<Artifact> artifacts = resolveArtifact(dependency, mavenParameters, transitively, pluginParameters, configurationVersion);
 			for (Artifact artifact : artifacts) {
-				File file = artifact.getFile();
-				if (file != null) {
-					files.add(file);
-				} else {
-					throw new MojoFailureException(String.format("Could not resolve dependency with descriptor '%s'.", descriptor));
+				if (!artifact.isOptional()) { //skip optional artifacts because getFile() will return null
+					File file = artifact.getFile();
+					if (file != null) {
+						files.add(file);
+					} else {
+						throw new MojoFailureException(String.format("Could not resolve dependency with descriptor '%s'.", descriptor));
+					}
 				}
 			}
 			if (files.size() == 0) {