Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not clear why build is breaking #151

Closed
cowwoc opened this issue Oct 9, 2016 · 6 comments
Closed

Not clear why build is breaking #151

cowwoc opened this issue Oct 9, 2016 · 6 comments

Comments

@cowwoc
Copy link

cowwoc commented Oct 9, 2016

If you look at the attached report, it's not clear why japicmp is failing the build. As far as I can tell, the report contains the following changes:

  • New interfaces added.
  • New methods added to concrete classes.

Neither of these should break source or binary compatibility.

japicmp.pdf

@siom79
Copy link
Owner

siom79 commented Oct 9, 2016

Are you using the latest version?

Newer versions of japicmp print out the exact reason for a source or binary incompatible change in the XML (for example):

<compatibilityChanges>
    <compatibilityChange>SUPERCLASS_CHANGED</compatibilityChange>
</compatibilityChanges>

Can you provide the XML file for the latest version? Thanks in advance.

@siom79 siom79 closed this as completed Oct 9, 2016
@cowwoc
Copy link
Author

cowwoc commented Oct 9, 2016

@siom79 Yes, please reopen this issue. I am using version 0.9.1. Unfortunately Github won't allow me to attach XML files (even ZIP doesn't work for some reason). Please download the file from https://bitbucket.org/cowwoc/requirements/downloads/japicmp.xml and attach it to this issue on my behalf.

The "cause" message I get starts with this text Breaking the build because there is at least one incompatibility: org.bitbucket.cowwoc.requirements.AssertionVerifier.addContext(java.lang.String,java.lang.Object):METHOD_NOW_THROWS_CHECKED_EXCEPTION

It goes on to list many more entries, but as I mentioned above all of them seem to be related to the addition of new interfaces that didn't exist before. #112 was supposed to fix this problem. Perhaps we are looking at a regression?

siom79 added a commit that referenced this issue Oct 9, 2016
@siom79
Copy link
Owner

siom79 commented Oct 9, 2016

Thanks for providing the details. It helped me to reconstruct your case. I could fix it on the develop branch and it will be released with 0.9.2.

@cowwoc
Copy link
Author

cowwoc commented Oct 9, 2016

Sounds good. I'll keep my eyes open for that release. Thanks!

@cowwoc
Copy link
Author

cowwoc commented Oct 13, 2016

@siom79 I tested the develop branch and the fix worked for me. Thanks!

@siom79
Copy link
Owner

siom79 commented Nov 7, 2016

Released with 0.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants