Method exclusion doesn't work

[rmetzger]

In our Japicmp config, we have the following exclude:

	<configuration>
					<parameter>
						<excludes combine.children="append">
							<!-- Exclude generated classes from api compatibility checks -->
							<exclude>*\$\$anon\$*</exclude>
							<exclude>org.apache.flink.streaming.api.scala.WindowedStream#aggregate(org.apache.flink.streaming.api.functions.aggregation.AggregationFunction$AggregationType,int)</exclude>
							<exclude>org.apache.flink.streaming.api.scala.AllWindowedStream#aggregate(org.apache.flink.streaming.api.functions.aggregation.AggregationFunction$AggregationType,int)</exclude>
						</excludes>
					</parameter>
				</configuration>

As you can see from the report, the exclude is understood by the plugin, but still, the method (with the exact same signature) is marked as missing.
http://people.apache.org/~rmetzger/japicmp.html

This is the branch were the error is happening: https://github.com/rmetzger/flink/tree/agg_follow_ups

[siom79]

Thanks for reporting. I used regular expressions for exclude matching but did not escape the dollar sign in inner classes.

Resolved on master branch. Will be released with 0.9.4.

[rmetzger]

Thanks a lot for looking into the issue so quickly!

Looking forward to the 0.9.4 release.

[siom79]

Meanwhile you can escape the dollar sign in your exclude: '$'.

[StephanEwen]

Thanks for the fast response!

[siom79]

Released with 0.9.4.