Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the addition of an unchecked "throws" be a source-incompatible change? #167

Closed
io7m opened this issue Mar 21, 2017 · 2 comments
Closed

Should the addition of an unchecked "throws" be a source-incompatible change? #167

io7m opened this issue Mar 21, 2017 · 2 comments

Comments

@io7m
Copy link
Contributor

io7m commented Mar 21, 2017

Hi.

When an API permits an implementation to throw an unchecked exception such as ArithmeticException, I often put the exceptions in the interface method's throws clauses for the purposes of documentation. However, japicmp unexpectedly seems to consider the addition of an unchecked exception to a method to be a source-incompatible change.

See the following example project:

https://github.com/io7m/japicmp-bug-20170321

The generated report says:

checked

Is this intended behaviour?
siom79 added a commit that referenced this issue Mar 24, 2017
@siom79
#167 method throwing in new version RuntimeException is no longer rep…
17b9bdf 
…orted to be source incompatible
@siom79
Copy link
Owner

siom79 commented Mar 24, 2017

Will be released with 0.10.0.

@siom79 siom79 closed this as completed Mar 24, 2017
@io7m
Copy link
Contributor Author

io7m commented Mar 24, 2017 •
edited
Loading

Nice work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@io7m @siom79