-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logstash formatter #132
Logstash formatter #132
Conversation
i'm waiting for this to be merged already! 👍 |
The thing that makes me a little hesitant here is to have the formatter in the main directory. How do you feel about putting it in a |
@sirupsen I think it's good idea to have special directory for formatters. I will create such directory and update pull request. |
Thanks! |
I put formatter to special directory. |
entry.Data["fields.type"] = v | ||
} | ||
entry.Data["type"] = f.Type | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the msg
field? Perhaps we should consider making prefixFieldClashes
public so you can use it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced msg
to message
because Logstash uses message
field for event description. So i can’t use prefixFieldClashes
.
This needs tests, then it's ready to get in master. |
I will write tests during some days. |
@sirupsen Test is ready. |
@sirupsen Thanks. |
Hi,
Pull request contains Logstash Formatter which write output log as Logstash Event (http://logstash.net/).
My previous PR is #130
Thanks,
Alex Demidov