Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logstash formatter #132

Merged
merged 4 commits into from
Mar 19, 2015
Merged

Logstash formatter #132

merged 4 commits into from
Mar 19, 2015

Conversation

alxdm
Copy link
Contributor

@alxdm alxdm commented Feb 20, 2015

Hi,

Pull request contains Logstash Formatter which write output log as Logstash Event (http://logstash.net/).
My previous PR is #130

Thanks,
Alex Demidov

@oryband
Copy link

oryband commented Mar 4, 2015

i'm waiting for this to be merged already! 👍

@sirupsen
Copy link
Owner

sirupsen commented Mar 4, 2015

The thing that makes me a little hesitant here is to have the formatter in the main directory. How do you feel about putting it in a formatters directory ala hooks?

@alxdm
Copy link
Contributor Author

alxdm commented Mar 5, 2015

@sirupsen I think it's good idea to have special directory for formatters. I will create such directory and update pull request.

@sirupsen
Copy link
Owner

sirupsen commented Mar 5, 2015

Thanks!

@alxdm
Copy link
Contributor Author

alxdm commented Mar 5, 2015

I put formatter to special directory.

entry.Data["fields.type"] = v
}
entry.Data["type"] = f.Type
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the msg field? Perhaps we should consider making prefixFieldClashes public so you can use it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced msg to message because Logstash uses message field for event description. So i can’t use prefixFieldClashes.

@sirupsen
Copy link
Owner

sirupsen commented Mar 9, 2015

This needs tests, then it's ready to get in master.

@alxdm
Copy link
Contributor Author

alxdm commented Mar 11, 2015

I will write tests during some days.

@alxdm
Copy link
Contributor Author

alxdm commented Mar 15, 2015

@sirupsen Test is ready.

@sirupsen sirupsen merged commit 2ec723c into sirupsen:master Mar 19, 2015
@alxdm alxdm deleted the logstash_formatter branch March 19, 2015 15:32
@alxdm
Copy link
Contributor Author

alxdm commented Mar 19, 2015

@sirupsen Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants