Fix data race issue in TextFormatter. Fix for https://github.com/Siru… #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have verified this fix on our internal CI system. |
|
@pengzhai printColored uses timestamp format too. The signature should be changed to pass timestampFormat, otherwise it will use an empty f.timestampFormat |
|
Good catch, @noxiouz! Fixed. |
|
Any additional comment, anyone? |
sirupsen
added a commit
that referenced
this pull request
Jul 22, 2015
Fix data race issue in TextFormatter. Fix for https://github.com/Siru…
|
sorry been on vacation |
devopstaku
pushed a commit
to devopstaku/logrus
that referenced
this pull request
Aug 9, 2016
Fix data race issue in TextFormatter. Fix for https://github.com/Siru…
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
Fix data race issue in TextFormatter. Fix for https://github.com/Siru…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…psen/logrus/issues/217.
Fix for the issue we just reported in #217