Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'it "should skip and jump"' becomes 'it "skips and jump"' #6

Open
henrik opened this issue Jun 19, 2013 · 4 comments
Open

'it "should skip and jump"' becomes 'it "skips and jump"' #6

henrik opened this issue Jun 19, 2013 · 4 comments

Comments

@henrik
Copy link

henrik commented Jun 19, 2013

Haven't considered edge cases – it may well be that any simple fix creates more of a mess than it fixes. But I wanted this listed among the issues, at least, even if it will be a wontfix.

@henrik
Copy link
Author

henrik commented Jun 19, 2013

Also, it is of course a test smell to have an "and" there, but still, it's been known to happen :)

@henrik
Copy link
Author

henrik commented Jun 19, 2013

Some cases to consider:

it "should store and then destroy a foo"
it "should store a foo and a bar"

@henrik
Copy link
Author

henrik commented Jun 20, 2013

I may attempt a patch if you don't mind. A part-of-speech tagger like engtagger seems viable:

>> tgr.add_tags("it should store and then destroy a foo")
=> "<prp>it</prp> <md>should</md> <vb>store</vb> <cc>and</cc> <rb>then</rb> <vb>destroy</vb> <det>a</det> <nn>foo</nn>"
>> tgr.add_tags("should store a foo and a bar")
=> "<md>should</md> <vb>store</vb> <det>a</det> <nn>foo</nn> <cc>and</cc> <det>a</det> <nn>bar</nn>"

@glennr
Copy link
Member

glennr commented Jun 20, 2013

Patches are welcome!

On Thu, Jun 20, 2013 at 6:51 AM, Henrik Nyh [email protected]:

I may attempt a patch if you don't mind. A part-of-speech tagger like
engtagger https://github.com/yohasebe/engtagger seems viable:

tgr.add_tags("it should store and then destroy a foo")
=> "itshouldstoreandthendestroyafoo"
tgr.add_tags("should store a foo and a bar")
=> "shouldstoreafooandabar"


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-19730822
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants