Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

去掉代码块预览选项，代码块默认预览高亮 #739

Closed
88250 opened this issue Dec 15, 2020 · 10 comments
Closed

去掉代码块预览选项，代码块默认预览高亮 #739

88250 opened this issue Dec 15, 2020 · 10 comments
Assignees
@88250 @Vanessa219
Labels
Enhancement
Milestone
0.5.41

Comments

@88250
Copy link
Member

88250 commented Dec 15, 2020 •
edited
Loading

在不开启编辑器设置的代码块预览时，焦点离开代码块编辑以后渲染为高亮预览，而不是现在的代码块文本。
@88250 88250 added this to the 0.5.4 milestone Dec 16, 2020
@MistRay
Copy link

MistRay commented Dec 16, 2020

👍 是个不错的方案,这样等于变相解决了 #703

@88250 88250 modified the milestones: 0.5.4, 0.5.5, 0.5.41 Dec 16, 2020
@88250 88250 changed the title 代码块默认高亮 去掉代码块预览选项，代码块默认高亮 Dec 17, 2020
88250 added a commit to 88250/lute that referenced this issue Dec 17, 2020
@88250
🎨 代码块默认高亮 siyuan-note/siyuan#739
d29561a
@88250 88250 closed this as completed Dec 17, 2020
88250 added a commit to siyuan-note/appearance that referenced this issue Dec 17, 2020
@88250
🎨 去掉代码块预览选项，代码块默认高亮 Fix siyuan-note/siyuan#739
af25a94
@88250 88250 changed the title 去掉代码块预览选项，代码块默认高亮 去掉代码块预览选项，代码块默认预览高亮 Dec 17, 2020
@MistRay
Copy link

MistRay commented Dec 18, 2020

不是要改成在不开启编辑器设置的代码块预览时，焦点离开代码块编辑以后渲染为高亮预览么,现在直接给开关弄没了...

@88250
Copy link
Member Author

88250 commented Dec 18, 2020

嗯，不要开关了，直接默认预览吧。

@MistRay
Copy link

MistRay commented Dec 18, 2020

我认为还是焦点离开代码块编辑以后渲染为高亮的方式的方式比较好,交互上会比较自然.
现在点击代码块的时候屏幕会跳一下,眼睛的焦点会改变,要重新寻找需要修改的位置(关注点).
这个重新寻找修改位置的过程其实是很耗时的.
我现在都是关闭代码块高亮使用,如果近期没法对编辑器做出优化,建议还是要个开关吧

@88250
Copy link
Member Author

88250 commented Dec 18, 2020

抱歉了，暂时先延后，后面再考虑，谢谢。

@jiangqizheng
Copy link

jiangqizheng commented Dec 22, 2020 •
edited
Loading

@88250 编辑代码块时下方跳出的代码块预览，非常影响编辑体验，尤其是笔记内很多代码的时候。如果目前无法快速实现类似typora的默认高亮，那是否能提供一个选项直接关闭代码块？就我而言，宁愿不要高亮...也不希望不断被干扰。

@88250
Copy link
Member Author

88250 commented Dec 23, 2020

@88250 编辑代码块时下方跳出的代码块预览，非常影响编辑体验，尤其是笔记内很多代码的时候。如果目前无法快速实现类似typora的默认高亮，那是否能提供一个选项直接关闭代码块？就我而言，宁愿不要高亮...也不希望不断被干扰。

收到，请再等待一下，我们目前正在调整编辑器，在 v0.6.0 之前会改进这一点，编辑时下方不进行预览。

@jiangqizheng
Copy link

@88250 v0.6.0了 😂，依旧没有改进，是被忽略了吗。

@88250
Copy link
Member Author

88250 commented Jan 14, 2021

@jiangqizheng 再将就一下，这块暂时顾及不上了……等后面重新考虑，抱歉了啊……

@guvmao
Copy link

guvmao commented Jan 23, 2021 •
edited
Loading

持续关注

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@88250 88250

@Vanessa219 Vanessa219

Labels
Enhancement
Projects
None yet
Milestone
0.5.41
Development

No branches or pull requests
5 participants
@88250 @Vanessa219 @jiangqizheng @MistRay @guvmao