Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tab drag highlighting #13549

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Improve tab drag highlighting #13549

merged 3 commits into from
Jan 8, 2025

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Dec 19, 2024

🎨 改进页签拖拽高亮

主要改进两个问题:

  1. 从上方或左侧将页签拖入 protyle 时动画方向的一点问题
  2. 从下方或右侧将页签拖入 protyle 时会出现预期外的滚动条

问题的录屏:

video.webm

然后还把位置判断的部分改了,之前的区域是方形的,现在改成梯形:

bdabc1b1955551b07f596542198a8b16

另外,有的地方我没看懂所以不知道有没有改对

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 19, 2024

另外我还发现一个问题,鼠标移动的速度超过高亮的动画效果之后就会出现异常,但我解决不了:

video.webm

@Vanessa219
Copy link
Member

区域位置目前是比较合理的,可以不用修改。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 20, 2024

我觉得梯形更合理一点

@Vanessa219
Copy link
Member

如果是梯形的话,上切换到左右就不太方便

Jietu20241221-091353-HD.mp4

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 21, 2024

这个是符合预期的,拖到中间靠左就是向左分屏,拖到中间靠上就是向上分屏。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 21, 2024

GoLand 也是梯形:

video.webm

@Vanessa219
Copy link
Member

IDEA 这样从上切换到左更方便

Jietu20241223-104318-HD.mp4

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 24, 2024

仔细看了一下,形状应该是这样,又改了一下:

469a131645a9a7548c24f4f56a597be

@Vanessa219
Copy link
Member

IDEA 是这样的
image

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 25, 2024

刚刚改了一下形状

@Vanessa219
Copy link
Member

改成啥了?

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 28, 2024

IDE 那个怪怪的,算起来又麻烦,我的想法是这样:

image

@Vanessa219
Copy link
Member

这个应该是上下拖拽距离不同的手感优化吧,1/3 太大了。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 28, 2024

我觉得左右分屏的 1/3 范围很方便,至少从半年多以前用到现在都很舒服。

不过上下分屏的范围感觉有点小,这次我增大了一点。

@Vanessa219 Vanessa219 added this to the 3.1.20 milestone Jan 7, 2025
@Vanessa219 Vanessa219 requested a review from 88250 January 7, 2025 16:39
@Vanessa219 Vanessa219 merged commit 4c011d5 into siyuan-note:dev Jan 8, 2025
@88250 88250 changed the title 🎨 改进页签拖拽高亮 Improve tab drag highlighting Jan 8, 2025
@TCOTC TCOTC deleted the dev-wnd branch January 8, 2025 06:58
@TCOTC TCOTC mentioned this pull request Jan 8, 2025
Vanessa219 added a commit that referenced this pull request Jan 8, 2025
@Vanessa219 Vanessa219 self-assigned this Jan 8, 2025
@Vanessa219 Vanessa219 self-requested a review January 8, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants