Fix & update CI #243
Merged
Fix & update CI #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as python 3.13 is available, and python 3.7 no longer available in github actions
to fix CI: ```cmake CMake Error at tmp/pybind11-master/build/eigen/blas/cmake_install.cmake:46 (file): file INSTALL cannot find "/home/runner/work/pybind11-stubgen/pybind11-stubgen/tmp/pybind11-master/build/eigen/blas/libeigen_blas_static.a": No such file or directory. Call Stack (most recent call first): tmp/pybind11-master/build/eigen/cmake_install.cmake:87 (include) ```
Closed
|
Thanks! I'm fine with convenient dev-dependencies. I totally understand the burden that comes with eigen. |
|
Any chance we could get a PyPI release with this included? |
Merged
sizmailov
added a commit
that referenced
this pull request
Feb 24, 2025
|
Took much more effort than I anticipated but v2.5.3 is out. |
|
Yay, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this project !
I wanted to work on Boost.Python support, and #57 shows that tests were missing. So I started to work on adding tests for that use case. But the CI on the current master currently fails, so in this PR I'm not working Boost Python, only updating the CI.
1st commit
I updated the python versions, because github actions has been upgraded to ubuntu 24.04, and python 3.7 is no longer available. While here, I told the CI to also test Python 3.13, now that is available
This fix failing CI run: https://github.com/nim65s/pybind11-stubgen/actions/runs/13078073831/job/36495024959
2nd commit
I enabled python 3.13 tests with a simple symlink.
This fixed failing CI run: https://github.com/nim65s/pybind11-stubgen/actions/runs/13077365254/job/36492732365
3rd commit
Cloning and building eigen fails, so I installed a prebuilt version instead, with the "cmeel-eigen" pip package. I'm the maintainer of that package, because I need eigen in many projects that I distribute on PyPI.
This fixed failing CI run: https://github.com/nim65s/pybind11-stubgen/actions/runs/13077365254/job/36492732892
NB: to add boost tests, downloading and building boost would take a huge amount of work and resources, so was thinking to use the "cmeel-boost" pre-built package instead. That's why I think adding a dependency on "cmeel-eigen" is cheap. But obviously, as the author of those monstrosities, I am biased.
4th commit
To use cmeel packages to build things with CMake, we need to
export CMAKE_PREFIX_PATH=$(cmeel cmake).This could probably be squashed into the previous commit.
5th commit
Pybind11 now seems to add a
_pybind11_conduit_v1_static method everywhere, so I guess we should exclude thatThis fixed failing CI run: https://github.com/nim65s/pybind11-stubgen/actions/runs/13077753258/job/36493969392
6th commit
Python 3.13 added 2 new dunder attributes:
__firstlineno__&__static_attributes__, so I also excluded those.This fixed failing CI run: https://github.com/nim65s/pybind11-stubgen/actions/runs/13077823166/job/36494187798