pytest 4 does not want us to call fixture functions

[sjaensch]

Tests started failing with pytest 4 due to us calling fixture functions from code. I'm not sure why that's not ok to do so, I guess we'll have to make the fixture function a wrapper around the real thing.

[macisamuele]

Surprising behaviour from pytest.
If that is what is needed to make tests green then I'm cool with it :)

🚢

[coveralls]

Coverage increased (+0.002%) to 98.723% when pulling 58d672f on fix_pytest4_compatibility into 51b91c0 on master.

[coveralls]

Coverage increased (+0.002%) to 98.723% when pulling 58d672f on fix_pytest4_compatibility into 51b91c0 on master.

[coveralls]

Coverage increased (+0.002%) to 98.723% when pulling 58d672f on fix_pytest4_compatibility into 51b91c0 on master.

[sjaensch]

Yep this is what the maintainers want us to do: pytest-dev/pytest#3950